Change example networks #2231
Merged
Change example networks #2231
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "patch-1" git@github.com:oscrx/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
thaJeztah
requested changes
Jan 2, 2020
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
changes itself look good, but could you sign-off your commit, otherwise CI won't pass and we won't be able to accept the PR (our bot provided some instructions above); also see https://github.com/docker/cli/blob/master/CONTRIBUTING.md#sign-your-work
Signed-off-by: Oscar Wieman <oscar@oscarr.nl>
Contributor
Author
|
Excuse me, I must not have payed enough attention. It should be fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Change the example networks to allowed private ranges (192.168.0.0/16) according to RFC1918.
- How I did it
With the editor.
- How to verify it
Check the diff.
- Description for the changelog
Change the network example to something allowed.
- A picture of a cute animal (not mandatory but encouraged)
