Skip to content

Conversation

@thaJeztah
Copy link
Member

addresses the missing CLI reference docs of #619 ("Docs missing for node platform constraints"). API changes are being addressed in moby/moby#40487

  • docs: service create: use markdown table for constraints
  • docs: service create: document non-matchin/exclude constraints
  • docs: service create: document os/arch constraints and more examples

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

ping @estesp @silvin-lubecki PTAL

---------------------|--------------------------|-----------------------------------------------
`node.id` | Node ID | `node.id==2ivku8v2gvtg4`
`node.hostname` | Node hostname | `node.hostname!=node-2`
`node.role` | Node role | `node.role==manager`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is an enum, we should add the values here in the matches column: Node role (manager|worker)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated; used a / instead of | because otherwise the markdown renderer might get confused 😓

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the node_constraint_docs_fixes branch from 31f3c4b to f26e9a3 Compare February 10, 2020 14:27
@silvin-lubecki silvin-lubecki merged commit ad05e28 into docker:master Feb 10, 2020
@thaJeztah thaJeztah deleted the node_constraint_docs_fixes branch February 10, 2020 14:36
@thaJeztah thaJeztah added this to the 20.03.0 milestone Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants