Skip to content

Add support for --limit-pids on service create / update and stacks (swarm) #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
silvin-lubecki merged 2 commits into from
Jun 22, 2020
Merged

Add support for --limit-pids on service create / update and stacks (swarm) #2503

silvin-lubecki merged 2 commits into from
Jun 22, 2020

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented May 7, 2020 •
edited
Loading

depends on:

relates to:

docker-compose / stack support was not yet added; I'll try to get that done asap

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 20.03.0 milestone May 7, 2020
@thaJeztah thaJeztah requested a review from albers as a code owner May 7, 2020 15:38
@thaJeztah
Copy link
Member Author

thaJeztah commented May 7, 2020

@silvin-lubecki PTAL

cpuguy83
cpuguy83 approved these changes May 7, 2020
View reviewed changes
Copy link
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

thaJeztah commented May 7, 2020

We're discussing changing the API to move the PidsLimit to the Resources section; I'll try to get that done today/tomorow so that we don't have to change the API after 20.0x code-freeze

@thaJeztah thaJeztah marked this pull request as draft May 7, 2020 20:17
@thaJeztah
Copy link
Member Author

thaJeztah commented May 7, 2020

(moved to "draft" meanwhile)

albers
albers approved these changes May 8, 2020
View reviewed changes
Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bash completion LGTM

@thaJeztah thaJeztah mentioned this pull request May 11, 2020
Merged
@thaJeztah thaJeztah force-pushed the pidslimit branch 3 times, most recently from 5e93453 to 9620753 Compare June 15, 2020 11:52
@thaJeztah thaJeztah changed the title Add support for --pids-limit on service create / service update Add support for --limit-pids on service create / update and stacks (swarm) Jun 15, 2020
@thaJeztah thaJeztah force-pushed the pidslimit branch 2 times, most recently from 8136289 to 0c10d08 Compare June 15, 2020 12:05
thaJeztah added 2 commits June 18, 2020 21:25
@thaJeztah
Add support for --limit-pids on service create / update (swarm)
395a6d5 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Add support for pids limit in stacks (swarm)
851eeb9 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2020

Codecov Report

Merging #2503 into master will increase coverage by 0.06%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##           master    #2503      +/-   ##
==========================================
+ Coverage   58.05%   58.12%   +0.06%     
==========================================
  Files         295      295              
  Lines       21165    21182      +17     
==========================================
+ Hits        12288    12311      +23     
+ Misses       7975     7967       -8     
- Partials      902      904       +2

@thaJeztah thaJeztah marked this pull request as ready for review June 18, 2020 19:39
@thaJeztah
Copy link
Member Author

thaJeztah commented Jun 18, 2020

@silvin-lubecki @cpuguy83 updated this one with the API changes, and renamed --pids-limit to --limit-pids, so that it matches the other limits for services PTAL

cpuguy83
cpuguy83 approved these changes Jun 19, 2020
View reviewed changes
Copy link
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

albers
albers approved these changes Jun 20, 2020
View reviewed changes
Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated completion LGTM

silvin-lubecki
silvin-lubecki approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 87db438 into docker:master Jun 22, 2020
@thaJeztah thaJeztah deleted the pidslimit branch June 22, 2020 13:13
This was referenced Dec 2, 2021
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@albers albers albers approved these changes

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

Assignees

No one assigned

Labels

area/swarm impact/changelog impact/documentation status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

Security Proposal: add "--pids-limit" to "docker service create/update" option list

5 participants

@thaJeztah @codecov-commenter @cpuguy83 @albers @silvin-lubecki