Skip to content

Add checks for dependencies that are not vendored #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaJeztah merged 1 commit into from
Jul 6, 2020
Merged

Add checks for dependencies that are not vendored #2596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@
appveyor.yml
build
circle.yml
/vndr.log
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@ cli/winresources/rsrc_amd64.syso
/docs/yaml/gen/
coverage.txt
profile.out
/vndr.log
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ dynbinary: ## build dynamically linked binary

vendor: vendor.conf ## check that vendor matches vendor.conf
rm -rf vendor
bash -c 'vndr |& grep -v -i clone'
bash -c 'vndr |& grep -v -i clone | tee ./vndr.log'
scripts/validate/check-git-diff vendor
scripts/validate/check-all-packages-vendored

.PHONY: authors
authors: ## generate AUTHORS file from git history
Expand Down
12 changes: 12 additions & 0 deletions scripts/validate/check-all-packages-vendored
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#!/bin/sh

set -eu

WARN_MISS_VENDOR='WARNING: dependency is not vendored'

if grep -q "$WARN_MISS_VENDOR" "./vndr.log"; then
echo
echo "Some dependencies are not vendored."
Comment thread
Madhur1997 marked this conversation as resolved.
echo
exit 1
fi