handle sigterm on running a plugin #2799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborvass
approved these changes
Oct 17, 2020
Member
|
Could you include the description in the commit message, instead of only on GitHub? 🤗 |
While running a plugin and canceling with SIGTERM, main process will close right away without letting the plugin close itself down and handle the exit code properly. Add appcontext that is useful for handling sigterm, as well as supporting sigkill when things go wrong. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
plugin-sigterm
branch
from
ae5acd2 to
857f585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running a plugin and canceling with SIGTERM, main process will close right away without letting the plugin close itself down and handle the exit code properly. Add
appcontextthat is useful for handling sigterm, as well as supporting sigkill when things go wrong.@AkihiroSuda @tiborvass
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com