Updates to bash completion for dockerd#282
Merged
Merged
Conversation
This adds bash completion for moby/moby#24237. Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
This adds bash completion for moby/moby#32944. Signed-off-by: Harald Albers <github@albersweb.de>
`--default-runtime` was added in moby/moby#22983 Signed-off-by: Harald Albers <github@albersweb.de>
This adds bash completion for moby/moby#23430. Signed-off-by: Harald Albers <github@albersweb.de>
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
==========================================
- Coverage 48.74% 48.43% -0.31%
==========================================
Files 173 173
Lines 11750 11748 -2
==========================================
- Hits 5727 5690 -37
- Misses 5661 5697 +36
+ Partials 362 361 -1 |
albers
changed the title
dockerddockerd
thaJeztah
approved these changes
Jul 3, 2017
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, left one nit, but no blocker for this PR
| return | ||
| ;; | ||
| --metrics-addr) | ||
| __docker_complete_local_interfaces --ip-only |
Member
There was a problem hiding this comment.
Wonder if it would be "cleaner" to have a separate function for ip-addresses
Collaborator
Author
There was a problem hiding this comment.
@thaJeztah updated, thanks for the hint.
albers
force-pushed
the
completion-daemon-updates
branch
from
5be3987 to
f4d3b13
Compare
`--metrics-addr` does not accept network interface names. Therefore `__docker_local_interfaces` was refined for this feature to optionally exclude interface names. Note that although `--metrics-addr` is experimental, it cannot be selectively enabled in bash completion because the test for the daemon running in experimental mode requires a running daemon. As this completion pertains to starting the daemon, this requirement is not met. Signed-off-by: Harald Albers <github@albersweb.de>
albers
force-pushed
the
completion-daemon-updates
branch
from
f4d3b13 to
0ea31af
Compare
Contributor
|
LGTM |
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
[17.11] bump version to 17.11.0-ce-rc1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of options were missing in bash completion of
dockerd.See individual commit messages for details and references.
ping @sdurrheimer for zsh completion