Skip to content

Conversation

@JonZeolla
Copy link
Contributor

@JonZeolla JonZeolla commented Feb 22, 2021

supersedes / closes #3273

- What I did
Fixed a typo in the docs that was introduced in d24201d

- How I did it
vi 😆

- How to verify it
Run the example command docker run --env-file env.list ubuntu env | grep -E 'VAR|USER' and confirm the output is expected.

- Description for the changelog
Fix mistake with env var example in docker run docs

- A picture of a cute animal (not mandatory but encouraged)
jonas-von-werne-9sXMFrCYxhw-unsplash

@JonZeolla JonZeolla requested a review from thaJeztah as a code owner February 22, 2021 21:08
Signed-off-by: Jon Zeolla <zeolla@gmail.com>
@JonZeolla JonZeolla force-pushed the fix-docker-run-env-docs branch from 9f7a7c0 to cb1bb72 Compare February 22, 2021 21:09
@JonZeolla
Copy link
Contributor Author

@thaJeztah anything else you need from me on this?

@thaJeztah
Copy link
Member

oh! I somehow missed this PR 😬

ironically, I just suggested exactly these changes in #3273, so let's merge this one instead; thanks!

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denisdefreyne
Copy link

I’d shake my fist at you for removing my name from the documentation, but it was quite incorrect anyway, so fair play to you @JonZeolla :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants