docs: add filter scope for command events and more cluster events#314
Conversation
2f9b8e6 to
6c25fee
Compare
|
LGTM |
6c25fee to
8b5e9fc
Compare
|
@vieux I updates this PR to add more details in docker events. And these things are described in the PR description. PTAL. Thanks a lot. |
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
==========================================
- Coverage 48.83% 48.68% -0.15%
==========================================
Files 186 186
Lines 12413 12416 +3
==========================================
- Hits 6062 6045 -17
- Misses 5977 5996 +19
- Partials 374 375 +1 |
|
ping @vieux @dnephin @thaJeztah |
thaJeztah
left a comment
There was a problem hiding this comment.
One nit, but LGTM otherwise
We may want to start thinking if we can present these in a different way, was thinking of a "matrix", but there's a lot of object types that don't share the same event-types, so possibly not a solution
| - `remove` | ||
| - `update` | ||
|
|
||
| #### secrets |
There was a problem hiding this comment.
Can you use a capital S here?
There was a problem hiding this comment.
Oh, my bad. Updated now. Thanks for the review. ☀️
Signed-off-by: allencloud <allen.sun@daocloud.io>
8b5e9fc to
8639c9b
Compare
Signed-off-by: allencloud allen.sun@daocloud.io
This PR adds filter scope for command events, while I think there are still some cluster events missing which are introduced in PR moby/moby#32421.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)