Skip to content

pin vndr to 9909bb2b8a0b7ea464527b376dc50389c90df587 #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vieux merged 1 commit into from
Jul 11, 2017
Merged

pin vndr to 9909bb2b8a0b7ea464527b376dc50389c90df587 #318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions dockerfiles/Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,11 @@ FROM golang:1.8.3-alpine

RUN apk add -U git make bash coreutils

RUN go get github.com/LK4D4/vndr && \
cp /go/bin/vndr /usr/bin && \
ARG VNDR_COMMIT=9909bb2b8a0b7ea464527b376dc50389c90df587
Copy link
Copy Markdown
Contributor

@mlaventure mlaventure Jul 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should go in hack/dockerfile/binaries-commits

hack/dockerfile/install-binaries.sh will override this version otherwise

Copy link
Copy Markdown
Member Author

@thaJeztah thaJeztah Jul 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlaventure this is the docker/cli repo, there's no hack/dockerfile/binaries-commits, so I just put it in the dockerfile

Copy link
Copy Markdown
Contributor

@mlaventure mlaventure Jul 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

Indeed 😅

RUN git clone https://github.com/LK4D4/vndr.git "/go/src/github.com/LK4D4/vndr" && \
cd "/go/src/github.com/LK4D4/vndr" && \
git checkout -q "$VNDR_COMMIT" && \
go build -v -o /usr/bin/vndr . && \
Copy link
Copy Markdown
Contributor

@dnephin dnephin Jul 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this going to break as soon as vndr adds a dependency, since we don't have a go get anywhere here?

go get will also get all the git files, so I think we can use go get to fetch, and still git checkout <sha>

Copy link
Copy Markdown
Member Author

@thaJeztah thaJeztah Jul 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this going to break as soon as vndr adds a dependency, since we don't have a go get anywhere here?

I assume it would vendor that dependency, but it's a ood point; I took the same approach as is used in moby/moby, so we may want to modify the approach there as well

rm -rf /go/src/* /go/pkg/* /go/bin/*

RUN go get github.com/jteeuwen/go-bindata/go-bindata && \
Expand Down