Skip to content

Conversation

@andrewhsu
Copy link
Contributor

To support other arch as mentioned in #31

Signed-off-by: Andrew Hsu andrewhsu@docker.com

Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@dnephin
Copy link
Contributor

dnephin commented May 8, 2017

needs a rebase to pickup circleci fixes

otherwise LGTM

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦁

@dnephin
Copy link
Contributor

dnephin commented May 11, 2017

I'm trying this out and I'm getting this error:

1 errors occurred:
--> linux/ppc64le error: exit status 2
Stderr: # github.com/docker/cli/vendor/github.com/docker/docker/pkg/term
vendor/github.com/docker/docker/pkg/term/term.go:53: undefined: tcget
vendor/github.com/docker/docker/pkg/term/term.go:62: undefined: tcset
vendor/github.com/docker/docker/pkg/term/term.go:71: undefined: tcget
vendor/github.com/docker/docker/pkg/term/term.go:84: undefined: tcset

I think we merged something in pkg/term recently

@tophj-ibm
Copy link
Contributor

hmm... I can't recreate this on x86 or ppc64le, but this looks like the case where pkg/term/tc_linux_cgo.go (which re-definies tcget/tcset) isn't being built for ppc64le because CGO isn't enabled.

@tiborvass and I did fix an issue with this last week, maybe this just needs a rebase.

@dnephin
Copy link
Contributor

dnephin commented May 12, 2017

To clarify, I saw the problem when I did a rebase. You can also see it on my branch in #78 if you enable it in linux-cross

@tophj-ibm
Copy link
Contributor

Gotcha. I opened up moby/moby#33180 which should fix the underlying issue. (syscall is way outdated)

@dnephin dnephin mentioned this pull request May 17, 2017
@dnephin
Copy link
Contributor

dnephin commented May 17, 2017

replaced by #104

@dnephin dnephin closed this May 17, 2017
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
update with latest from docker-ce-packaging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants