Cleanup leftovers for --stream build flag #3305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
rm-stream
branch
from
dc9d705 to
f8d0246
Compare
thaJeztah
approved these changes
Sep 20, 2021
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
I was considering if we needed to change thew warning to an error (slightly more informative than "unknown flag: --stream"), but I guess it's been a year that we printed this message, so probably ok to remove.
Member
|
@tonistiigi @cpuguy83 ptal |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3305 +/- ##
==========================================
+ Coverage 58.81% 59.19% +0.38%
==========================================
Files 286 288 +2
Lines 24640 24637 -3
==========================================
+ Hits 14491 14583 +92
+ Misses 9265 9170 -95
Partials 884 884 |
Member
Author
|
@thaJeztah Rebased in case we still want this. |
cpuguy83
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #2809
--streambuild flag is marked as removed since Docker 20.10.- What I did
Cleanup leftovers for
--streambuild flag.- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
cc @thaJeztah
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com