completion v2: some small follow-ups #3603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent completion on "create" subcommands to prevent them from completing with local filenames - Add completion for "docker image save" - Add completion for "docker image tag" - Disable completion for "docker login" - Exclude "paused" containers for "docker container attach" and "docker container exec" Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
rumpl
approved these changes
May 12, 2022
Member
Author
|
Bringing this one in (as discussed), but if there's things to address, I'm happy to fix them in a follow-up 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
from completing with local filenames
"docker container exec"
- A picture of a cute animal (not mandatory but encouraged)