fixed word network on volume_ls.md#375
Merged
Merged
Conversation
hernandanielg
requested review from
mdlinville,
thaJeztah and
vdemeester
as code owners
|
Please sign your commits following these rules: $ git clone -b "doc/fix_volume_ls" git@github.com:hernandanielg/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Hernan Garcia <hernandanielg@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
==========================================
+ Coverage 46.13% 46.14% +<.01%
==========================================
Files 193 193
Lines 16073 16073
==========================================
+ Hits 7416 7417 +1
+ Misses 8270 8269 -1
Partials 387 387 |
Contributor
Author
|
This is related to cc @thaJeztah |
mdlinville
approved these changes
Jul 24, 2017
Contributor
mdlinville
left a comment
mdlinville
left a comment
There was a problem hiding this comment.
LGTM, what a mistake. Thanks for finding it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Changed Network to Volume on volume_ls.md
- How I did it
- How to verify it
- Description for the changelog
Fixed wrong reference to network items on
volume_ls.md- A picture of a cute animal (not mandatory but encouraged)