Skip to content

Conversation

@thaJeztah
Copy link
Member

Migrating these functions to allow them being shared between moby, docker/cli,
and containerd, and to allow using them without importing all of sys / system,
which (in containerd) also depends on hcsshim and more.

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah changed the title replace pkg/system Sequential funcs with moby/sys/sequential [WIP] replace pkg/system Sequential funcs with moby/sys/sequential Aug 27, 2022
@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Aug 27, 2022
@thaJeztah thaJeztah added this to the 22.06.0 milestone Aug 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2022

Codecov Report

Merging #3755 (0e3d542) into master (d89b5db) will not change coverage.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##           master    #3755   +/-   ##
=======================================
  Coverage   59.14%   59.14%           
=======================================
  Files         289      289           
  Lines       24680    24680           
=======================================
  Hits        14597    14597           
  Misses       9212     9212           
  Partials      871      871           

@thaJeztah
Copy link
Member Author

For reviewers looking at the "+ LOC";

Screenshot 2022-08-27 at 15 42 40

  • most of the added lines from the new module is because it'll vendor another copy of the Apache LICENSE
  • this should all be temporary; once other dependencies have migrated to this new package, the extra copy of these functions should go away

Migrating these functions to allow them being shared between moby, docker/cli,
and containerd, and to allow using them without importing all of sys / system,
which (in containerd) also depends on hcsshim and more.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title [WIP] replace pkg/system Sequential funcs with moby/sys/sequential replace pkg/system Sequential funcs with moby/sys/sequential Aug 29, 2022
Copy link
Contributor

@sam-thibault sam-thibault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

Thx! Bringing this one in 👍

@thaJeztah thaJeztah merged commit b22afea into docker:master Aug 29, 2022
@thaJeztah thaJeztah deleted the sequential branch August 29, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants