Skip to content

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Sep 2, 2022


Update to go 1.19.1 to address CVE-2022-27664, CVE-2022-32190

From the mailing list:

We have just released Go versions 1.19.1 and 1.18.6, minor point releases.
These minor releases include 2 security fixes following the security policy:

  • net/http: handle server errors after sending GOAWAY
    A closing HTTP/2 server connection could hang forever waiting for a clean
    shutdown that was preempted by a subsequent fatal error. This failure mode
    could be exploited to cause a denial of service.

    Thanks to Bahruz Jabiyev, Tommaso Innocenti, Anthony Gavazzi, Steven Sprecher,
    and Kaan Onarlioglu for reporting this.

    This is CVE-2022-27664 and Go issue https://go.dev/issue/54658.

  • net/url: JoinPath does not strip relative path components in all circumstances
    JoinPath and URL.JoinPath would not remove ../ path components appended to a
    relative path. For example, JoinPath("https://go.dev", "../go") returned the
    URL https://go.dev/../go, despite the JoinPath documentation stating that
    ../ path elements are cleaned from the result.

    Thanks to q0jt for reporting this issue.

    This is CVE-2022-32190 and Go issue https://go.dev/issue/54385.

Release notes:

go1.19.1 (released 2022-09-06) includes security fixes to the net/http and
net/url packages, as well as bug fixes to the compiler, the go command, the pprof
command, the linker, the runtime, and the crypto/tls and crypto/x509 packages.
See the Go 1.19.1 milestone on the issue tracker for details.

https://github.com/golang/go/issues?q=milestone%3AGo1.19.1+label%3ACherryPickApproved

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #3767 (3a17d8a) into master (2ae9e21) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3767   +/-   ##
=======================================
  Coverage   59.25%   59.25%           
=======================================
  Files         288      288           
  Lines       24630    24630           
=======================================
  Hits        14595    14595           
  Misses       9164     9164           
  Partials      871      871           

@thaJeztah
Copy link
Member Author

LOL, I was just about to check what version of GolangCI we were running;

#17 8.935 panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
#17 8.935 
#17 8.935 goroutine 1 [running]:
#17 8.935 github.com/go-critic/go-critic/checkers.init.22()
#17 8.936 	github.com/go-critic/go-critic@v0.6.2/checkers/embedded_rules.go:46 +0x4b4
#17 ERROR: executor failed running [/bin/sh -c golangci-lint run]: exit code: 2

@thaJeztah thaJeztah force-pushed the bump_go_119 branch 3 times, most recently from c377c4e to b2bd45b Compare September 6, 2022 20:21
@thaJeztah thaJeztah changed the title update to golang 1.19 update to golang 1.19.1 Sep 6, 2022
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
From the mailing list:

We have just released Go versions 1.19.1 and 1.18.6, minor point releases.
These minor releases include 2 security fixes following the security policy:

- net/http: handle server errors after sending GOAWAY
  A closing HTTP/2 server connection could hang forever waiting for a clean
  shutdown that was preempted by a subsequent fatal error. This failure mode
  could be exploited to cause a denial of service.

  Thanks to Bahruz Jabiyev, Tommaso Innocenti, Anthony Gavazzi, Steven Sprecher,
  and Kaan Onarlioglu for reporting this.

  This is CVE-2022-27664 and Go issue https://go.dev/issue/54658.

- net/url: JoinPath does not strip relative path components in all circumstances
  JoinPath and URL.JoinPath would not remove `../` path components appended to a
  relative path. For example, `JoinPath("https://go.dev", "../go")` returned the
  URL `https://go.dev/../go`, despite the JoinPath documentation stating that
  `../` path elements are cleaned from the result.

  Thanks to q0jt for reporting this issue.

  This is CVE-2022-32190 and Go issue https://go.dev/issue/54385.

Release notes:

go1.19.1 (released 2022-09-06) includes security fixes to the net/http and
net/url packages, as well as bug fixes to the compiler, the go command, the pprof
command, the linker, the runtime, and the crypto/tls and crypto/x509 packages.
See the Go 1.19.1 milestone on the issue tracker for details.

https://github.com/golang/go/issues?q=milestone%3AGo1.19.1+label%3ACherryPickApproved

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah marked this pull request as ready for review September 8, 2022 08:40
@thaJeztah
Copy link
Member Author

@rumpl ptal 👍

@thaJeztah thaJeztah merged commit 813bd79 into docker:master Sep 8, 2022
@thaJeztah thaJeztah deleted the bump_go_119 branch September 8, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants