cli/command: DockerCli: CurrentContext(): resolve dynamically #3884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store a reference to the options in the client, so that they can be used for later use. Now that resolveContextName() is a very lightweight function we can also dynamically get its value and use it for cli.CurrentContext(). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
area/context
kind/refactor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3884 +/- ##
=======================================
Coverage 59.22% 59.23%
=======================================
Files 285 287 +2
Lines 24653 24656 +3
=======================================
+ Hits 14601 14605 +4
Misses 9168 9168
+ Partials 884 883 -1 |
Member
Author
|
FWIW; moved this back to draft, as I'm still on the fence if we should resolve the context once at startup, or dynamically. Reason is that other properties (e.g. "DockerEndpoint" may not be resolved dynamically, so it would not make much sense to resolve this one dynamically. So I may reduce this change back to only storing the options. |
Member
Author
|
closing in favour of #3847 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store a reference to the options in the client, so that they can be used for later use. Now that resolveContextName() is a very lightweight function we can also dynamically get its value and use it for cli.CurrentContext().
- A picture of a cute animal (not mandatory but encouraged)