Dockerfile: add ALPINE_VERSION build-arg#3896
Merged
thaJeztah merged 1 commit intodocker:masterfrom Dec 4, 2022
Merged
Conversation
thaJeztah
added
status/2-code-review
kind/bugfix
Member
Author
|
@crazy-max PTAL |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3896 +/- ##
=======================================
Coverage 59.22% 59.22%
=======================================
Files 287 287
Lines 24712 24712
=======================================
Hits 14635 14635
Misses 9192 9192
Partials 885 885 |
crazy-max
reviewed
Dec 4, 2022
| FROM --platform=$BUILDPLATFORM tonistiigi/xx:${XX_VERSION} AS xx | ||
|
|
||
| FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-${BASE_VARIANT} AS build-base-alpine | ||
| FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-${BASE_VARIANT}${ALPINE_VERSION} AS build-base-alpine |
Member
There was a problem hiding this comment.
Suggested change
| FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-${BASE_VARIANT}${ALPINE_VERSION} AS build-base-alpine | |
| FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS build-base-alpine |
BASE_VARIANT can be set to alpine here.
Member
Author
There was a problem hiding this comment.
oh! makes sense yes, this one is always alpine.
This allows us to pin to a specific version of Alpine, in case the golang:alpine image switches to a newer version, which may at times be incompatible, e.g. see moby/moby#44570 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
add_alpine_version
branch
from
7b56eba to
1b0d6fc
Compare
Member
Author
|
@crazy-max updated; PTAL |
crazy-max
approved these changes
Dec 4, 2022
Member
Author
|
Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
This allows us to pin to a specific version of Alpine, in case the golang:alpine image switches to a newer version, which may at times be incompatible, e.g. see moby/moby#44570
- A picture of a cute animal (not mandatory but encouraged)