cmd/docker: make feature detection lazy again #3904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 20ba591 fixed incorrect feature detection in the CLI, but introduced a regression; previously the "ping" would only be executed if needed (see b397391), but by not inlining the call to `ServerInfo()` would now always be called. This patch inlines the code again to only execute the "ping" conditionally, which allows it to be executed lazily (and omitted for commands that don't require a daemon connection). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vvoland
approved these changes
Dec 6, 2022
This was referenced Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 20ba591 (#3901) fixed incorrect feature detection in the CLI, but introduced a regression; previously the "ping" would only be executed if needed (see b397391 / #2424), but by not inlining the call to
ServerInfo()would now always be called.This patch inlines the code again to only execute the "ping" conditionally, which allows it to be executed lazily (and omitted for commands that don't require a daemon connection).
- A picture of a cute animal (not mandatory but encouraged)