-
Notifications
You must be signed in to change notification settings - Fork 2.1k
cli/flags: remove outdated TODO #3915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
approved these changes
Dec 15, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3915 +/- ##
==========================================
- Coverage 59.22% 58.85% -0.38%
==========================================
Files 287 285 -2
Lines 24726 24717 -9
==========================================
- Hits 14643 14546 -97
- Misses 9198 9287 +89
+ Partials 885 884 -1 |
Member
Author
|
Oh! interesting; looks like we have a panic in a test (looks like it may need some fixes for |
Libtrust was only used for pushing schema 2, v1 images, which is no longer supported; this TODO was likely left from when the CLI and daemon were in the same repository. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
a89d4f1 to
2f733b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libtrust was only used for pushing schema 2, v1 images, which is no longer supported; this TODO was likely left from when the CLI and daemon were in the same repository.
- A picture of a cute animal (not mandatory but encouraged)