cli/command: remove deprecated Stream types #4174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
impact/deprecation
status/2-code-review
kind/refactor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4174 +/- ##
=======================================
Coverage 58.86% 58.87%
=======================================
Files 572 570 -2
Lines 49572 49564 -8
=======================================
Hits 29182 29182
+ Misses 18624 18616 -8
Partials 1766 1766 |
These were deprecated in eb0ba4f, which was part of docker 19.03, so users should have had a chance to migrate. This removes InStream, OutStream, NewInStream and NewOutStream Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
remove_deprecated_streams
branch
from
b5c2fc6 to
c180202
Compare
sam-thibault
approved these changes
Apr 26, 2023
vvoland
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were deprecated in eb0ba4f (#1633), which was part of docker 19.03, so users should have had a chance to migrate.
This removes InStream, OutStream, NewInStream and NewOutStream
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)