Skip to content

Conversation

@thaJeztah
Copy link
Member

Contains various performance optimisations.

full diff: mattn/go-runewidth@v0.0.13...v0.0.14

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels May 3, 2023
Contains various performance optimisations.

full diff: mattn/go-runewidth@v0.0.13...v0.0.14

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the update_runewidth branch from 0ecde22 to 44fce07 Compare May 5, 2023 00:37
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

Codecov Report

Merging #4251 (44fce07) into master (f7600fb) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4251   +/-   ##
=======================================
  Coverage   58.88%   58.88%           
=======================================
  Files         570      570           
  Lines       49566    49566           
=======================================
  Hits        29186    29186           
  Misses      18616    18616           
  Partials     1764     1764           

@thaJeztah thaJeztah requested review from laurazard and vvoland May 5, 2023 00:48
@thaJeztah thaJeztah added this to the 24.0.0 milestone May 5, 2023
Copy link
Collaborator

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit b403a49 into docker:master May 5, 2023
@thaJeztah thaJeztah deleted the update_runewidth branch May 5, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants