rewrite TestParseRestartPolicy to use sub-tests #4533
Merged
+76
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
area/testing
kind/refactor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4533 +/- ##
=======================================
Coverage 59.40% 59.40%
=======================================
Files 288 288
Lines 24787 24787
=======================================
Hits 14725 14725
Misses 9181 9181
Partials 881 881 |
thaJeztah
force-pushed
the
test_table_TestParseRestartPolicy
branch
from
167632b to
7958ccf
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
test_table_TestParseRestartPolicy
branch
2 times, most recently
from
610b52d to
0e52033
Compare
2 tasks
vvoland
reviewed
Aug 28, 2023
Also make it slightly more clearer we're returning a default (empty) policy if the input is empty. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
test_table_TestParseRestartPolicy
branch
from
0e52033 to
261c18f
Compare
vvoland
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in preparation of other changes 😄
- A picture of a cute animal (not mandatory but encouraged)