Test fixes needed for upgrading ci runners and engine #4867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gine version Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4867 +/- ##
=======================================
Coverage 61.31% 61.31%
=======================================
Files 287 287
Lines 20058 20058
=======================================
Hits 12298 12298
Misses 6867 6867
Partials 893 893 |
Member
|
@krissetto should we merge this one, and then rebase the other PR? |
Contributor
Author
Sounds good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Minor test fixes that are necessary for running tests on updated ci runners and more recent versions of the engine
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)