Skip to content

Conversation

@vvoland
Copy link
Collaborator

@vvoland vvoland commented Jun 11, 2024

This wraps the cli stderr stream the same way as stdin and stdout, which extends the stream with TTY-related methods.

@vvoland vvoland added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Jun 11, 2024
@vvoland vvoland added this to the 27.0.0 milestone Jun 11, 2024
@vvoland vvoland self-assigned this Jun 11, 2024
This wraps the cli stderr stream the same way as stdin and stdout, which
extends the stream with TTY-related methods.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland force-pushed the cli-err-wrapstream branch from 1c0e0c1 to 6b93cf2 Compare June 11, 2024 15:59
Copy link
Collaborator

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 8c6e43f into docker:master Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants