docs/generate: remove uses of pkg/errors #5784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5784 +/- ##
=======================================
Coverage 59.28% 59.28%
=======================================
Files 358 358
Lines 29830 29830
=======================================
Hits 17685 17685
Misses 11173 11173
Partials 972 972 🚀 New features to boost your workflow:
|
thaJeztah
force-pushed
the
docs_gen_no_pkg_errors
branch
from
053cb74 to
101862c
Compare
thaJeztah
changed the title
thaJeztah
force-pushed
the
docs_gen_no_pkg_errors
branch
from
101862c to
8cc7e55
Compare
thaJeztah
added
status/2-code-review
kind/refactor
While there may be reasons to keep pkg/errors in production code, we don't need them for this generator code. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
docs_gen_no_pkg_errors
branch
from
8cc7e55 to
2f79598
Compare
Benehiko
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there may be reasons to keep pkg/errors in production code, we don't need them for these tests.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)