Update docker dependency for pkg/term #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crosbymichael
changed the title
Contributor
Author
|
Quickly hold off on this, i need to make one more update to the non-cgo version of the term package to fix static builds |
Contributor
|
moby/moby#33128 merged! 😄 🎉 |
crosbymichael
force-pushed
the
update-term
branch
2 times, most recently
from
b59035d to
bccd8b4
Compare
Contributor
Author
|
Ok, updated this to the latest docker after the update pr is merged. This is ready for review and merge. Sorry about the wait |
We need the `pkg/term` dep from docker with OPOST added to the MakeRaw call in order for the new runc 1.0 integration to work properly. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
crosbymichael
force-pushed
the
update-term
branch
from
bccd8b4 to
56ea98f
Compare
Contributor
There seems to be an issue with vendoring |
Contributor
Author
|
@mlaventure what??? ;) updated |
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
Update deprecated.md for removal of --email flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the
pkg/termdep from docker with OPOST added to the MakeRawcall in order for the new runc 1.0 integration to work properly.
Signed-off-by: Michael Crosby crosbymichael@gmail.com