add local fork of github.com/docker/docker/builder/remotecontext

[thaJeztah]

• relates to Move builder under daemon moby/moby#50365 (comment)

---

add local fork of github.com/docker/docker/builder/remotecontext

Adds a local fork of this package for use in the classic builder.

Code was taken at commit d33d46d01656e1d9ee26743f0c0d7779f685dd4e.

Migration was done using the following steps:

# install filter-repo (https://github.com/newren/git-filter-repo/blob/main/INSTALL.md)
brew install git-filter-repo

# create a temporary clone of docker
cd ~/Projects
git clone https://github.com/docker/docker.git build_context_temp
cd build_context_temp

# commit taken from
git rev-parse --verify HEAD
d33d46d01656e1d9ee26743f0c0d7779f685dd4e

git filter-repo --analyze

# remove all code, except for the remotecontext packages, and move to build/internal docs and previous locations of it
git filter-repo \
  --path 'builder/remotecontext/git' \
  --path 'builder/remotecontext/urlutil' \
  --path-rename builder/remotecontext:cli/command/image/build/internal


# go to the target repository
cd ~/go/src/github.com/docker/cli

# create a branch to work with
git checkout -b fork_remotecontext

# add the temporary repository as an upstream and make sure it's up-to-date
git remote add build_context_temp ~/Projects/build_context_temp
git fetch build_context_temp

# merge the upstream code
git merge --allow-unrelated-histories --signoff -S build_context_temp/master

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

[thaJeztah]

Fixed; had that done in my previous attempt, but should be good now

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

[thaJeztah]

Looks like we may need to add some extra things in the dev container;

#18 66.08 === FAIL: cli/command/image/build/internal/git TestCheckoutGit (0.14s)
#18 66.08     gitutils_test.go:179: git version 2.49.1
#18 66.08     gitutils_test.go:239: Initialized empty Git repository in /tmp/TestCheckoutGit3938753936/001/repo/.git/
#18 66.08     gitutils_test.go:254: [master (root-commit) 2a3382f] First commit
#18 66.08          4 files changed, 5 insertions(+)
#18 66.08          create mode 100644 Dockerfile
#18 66.08          create mode 120000 absolutelink
#18 66.08          create mode 120000 parentlink
#18 66.08          create mode 100644 subdir/Dockerfile
#18 66.08     gitutils_test.go:255: Switched to a new branch 'test'
#18 66.08     gitutils_test.go:261: [test 5094963] Branch commit
#18 66.08          2 files changed, 3 insertions(+), 2 deletions(-)
#18 66.08     gitutils_test.go:262: Switched to branch 'master'
#18 66.08     gitutils_test.go:266: Initialized empty Git repository in /tmp/TestCheckoutGit3938753936/001/subrepo/.git/
#18 66.08     gitutils_test.go:273: [master (root-commit) 0922701] Subrepo initial
#18 66.08          1 file changed, 1 insertion(+)
#18 66.08          create mode 100644 subfile
#18 66.08 2025/07/16 14:30:17 cgi: no headers
#18 66.08     gitutils_test.go:210: git-http-backend: git: 'http-backend' is not a git command. See 'git --help'.
#18 66.08         
#18 66.08     gitutils_test.go:210: git-http-backend: 
#18 66.08     gitutils_test.go:275: Cloning into '/tmp/TestCheckoutGit3938753936/001/repo/sub'...
#18 66.08         fatal: unable to access 'http://127.0.0.1:44973/subrepo/': The requested URL returned error: 500
#18 66.08         fatal: clone of 'http://127.0.0.1:44973/subrepo' into submodule path '/tmp/TestCheckoutGit3938753936/001/repo/sub' failed
#18 66.08     gitutils_test.go:275: assertion failed: error is not nil: exit status 128

[thaJeztah]

Another flaky test; looks like we may not be matching errors correctly (or just race condition) 🤔

65.72 === Failed
65.72 === FAIL: cli/command/plugin TestUpgradePromptTermination (0.00s)
65.72     upgrade_test.go:37: assertion failed: error is "plugin upgrade has been cancelled" (plugin.cancelledErr), not "prompt terminated" (prompt.ErrTerminated prompt.cancelledErr)

[thaJeztah]

@Benehiko @vvoland this should be ready for review