-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Move notary to its new location #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vendor.conf
Outdated
| github.com/spf13/cobra 7b2c5ac9fc04fc5efafb60700713d4fa609b777b | ||
| github.com/spf13/pflag 97afa5e7ca8a08a383cb259e06636b5e2cc7897f | ||
| github.com/stretchr/testify 4d4bfba8f1d1027c4fdbe371823030df51419987 | ||
| github.com/theupdateframework/notary 8a1de3cfc3f1408e54d6364fc949214a4883a9f3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be updated to 05985dc5d1c71ee6c387e9cd276a00b9d424af53 (the commit that moves the import paths) or later cc @endophage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Forgot about references inside notary itself 🤦♂️
The https://github.com/docker/notary repository has moved to https://github.com/theupdateframework/notary Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
d4e3029 to
6cd5806
Compare
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
=======================================
Coverage 50.02% 50.02%
=======================================
Files 216 216
Lines 17676 17676
=======================================
Hits 8842 8842
Misses 8391 8391
Partials 443 443 |
dnephin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
riyazdf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @thaJeztah!
cpuguy83
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@thaJeztah thanks for doing this before I got to it! |
|
You're welcome! 👍 |
The https://github.com/docker/notary repository has moved to https://github.com/theupdateframework/notary
fixes #643
full diff; notaryproject/notary@5d55a30...05985dc