Fix and simplify bash completion for service env, mounts and labels #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
==========================================
+ Coverage 53.44% 53.45% +<.01%
==========================================
Files 218 218
Lines 14613 14613
==========================================
+ Hits 7810 7811 +1
+ Misses 6322 6321 -1
Partials 481 481 |
albers
force-pushed
the
completion-service-options
branch
from
e32cee7 to
2ee36c8
Compare
`service create` and `service update` both used to have `--env`, `--label` and `--mount` options. These options now are only valid for `service create`. `service update` got corresponding `--xxx-add|rm` options instead. Signed-off-by: Harald Albers <github@albersweb.de>
Previously, the completions for `--xxx` and the corresponding `-xxx-add` and `-xxx-rm` options were defined in separate blocks. This caused a lot of duplicated code. This PR removes duplication for xxx=config|group|host|placement-pref|secret. Now the blocks for `create` and `update` only contain completions for options that either only exist for the particular command or are specific to it (completions for `--env-rm` and `--env|env-add` differ). Signed-off-by: Harald Albers <github@albersweb.de>
albers
force-pushed
the
completion-service-options
branch
from
2ee36c8 to
f2b42bb
Compare
Collaborator
Author
|
rebased because of a conflict with |
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
Fix and simplify bash completion for service env, mounts and labels Upstream-commit: 26a2a45 Component: cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service createandservice updateboth used to have--env,--labeland--mountoptions.These options now are only valid for
service create.service updategot corresponding--xxx-add|rmoptions instead.Also removes some duplication between the completions for
--xxxand the corresponding-xxx-addand-xxx-rmoptions.