Support building a dynbinary #76
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Merged
seemethere
reviewed
May 12, 2017
| @@ -1,4 +1,6 @@ | |||
| #!/usr/bin/env sh | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
👍 This was causing builds to fail in ubuntu-xenial containers due to the default /usr/bin/env sh not having source
Contributor
Author
|
I'm going to close this, it's included in #78 |
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
cherry-pick container/stream/attach: use pools.Copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75
cc @tiborvass @andrewhsu
Try it with