Move duration opts into an opts package#77
Conversation
vdemeester
force-pushed
the
move-duration-opts
branch
from
c6bfb3f to
db3d4ef
Compare
|
@vdemeester should we consider moving the moby/opts package to docker/cli repo as part of the reorg effort ? #62 is having a similar issue and @abhinandanpb decided to add the option as part of moby/opts to bring it back into docker/cli as part of the reorg. WDYT ? |
|
@mavenugo yes, I think @dnephin opened an issue in |
|
I agree with this change, but I think we should move in moby/moby/opts first, otherwise this is going to cause a bunch of conflicts |
|
Discussed it with @dnephin, preparing a PR for the move of |
| ) | ||
|
|
||
| // PositiveDurationOpt is an option type for time.Duration that uses a pointer. | ||
| // It bahave similarly to DurationOpt but only allows positive duration values. |
|
Seems okay as a temporary step, but I think it's better to remove However, if you do this, make sure it doesn't affect the CLI help output, because I remember there were some differences between how they format defaults. IIRC, |
vdemeester
force-pushed
the
move-duration-opts
branch
3 times, most recently
from
9389df1 to
7bd5712
Compare
|
Updated and rebase 👼 |
| limitMemBytes opts.MemBytes | ||
| resCPU opts.NanoCPUs | ||
| resMemBytes opts.MemBytes | ||
| limitCPU dopts.NanoCPUs |
There was a problem hiding this comment.
yep, bad rebase 😝
There was a problem hiding this comment.
should be fixed and green 📗
There was a problem hiding this comment.
lol, I was actually looking at that and scratching my head if I overlooked something 😄
They have nothing to do with service and could be used on their own. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
move-duration-opts
branch
from
7bd5712 to
b5182ba
Compare
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
holding of merging, because there's some other PR's that are needed for 17.06, not sure if they're affected
|
removing the milestone, because I don't know if this ends up in 17.06 or 17.07 |
Add pigz to recommended packages Upstream-commit: a6543ceeff408dfa9cbb4e75d013bc05bda09c32 Component: packaging
6 participants
They have nothing to do with service and could be used on their own.
🦁
– doing that because I wanted to re-use it without having to import/vendor
servicepackage.Signed-off-by: Vincent Demeester vincent@sbr.pm