Skip to content

Conversation

@unkaktus
Copy link
Contributor

- What I did
Converted string constant into the function it should be.

- How I did it
Edited the file.

- How to verify it

GOOS=openbsd GOARCH=amd64 go build cli/config/credentials

- Description for the changelog

Fix compilation of defaultCredentialStore() on unsupported platforms.

Signed-off-by: Ivan Markin <sw@nogoegst.net>
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@unkaktus unkaktus mentioned this pull request Feb 10, 2018
9 tasks
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov-io
Copy link

Codecov Report

Merging #872 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #872   +/-   ##
=======================================
  Coverage   53.19%   53.19%           
=======================================
  Files         246      246           
  Lines       16021    16021           
=======================================
  Hits         8522     8522           
  Misses       6929     6929           
  Partials      570      570

@dnephin dnephin merged commit dcd6298 into docker:master Feb 12, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.03.0 milestone Feb 12, 2018
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
…redential-store

Fix compilation of defaultCredentialStore() on unsupported platforms
Upstream-commit: dcd6298
Component: cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants