Don't prompt for github creds in unit test #920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
==========================================
- Coverage 53.55% 53.54% -0.01%
==========================================
Files 262 262
Lines 16602 16602
==========================================
- Hits 8891 8890 -1
- Misses 7121 7122 +1
Partials 590 590 |
thaJeztah
approved these changes
Mar 7, 2018
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
This test has been a thorn in my side for a long time.
Guilty as charged 😂
LGTM, thanks for this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been a thorn in my side for a long time. Every time I run unit tests for the
imagepackage it prompts for credentials and I have to hit enter a couple times for the test to run.The ideal fix would be to refactor
runBuild(#294) so that we can unit test the logic without actually performing a clone. Since that PR is stalled out this change will at least remedy the immediate problem.Instead of using a non-existant repo, use a very small repo.