Orchestrator column #973
Merged
Orchestrator column #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Seems like you have test failure 😓 |
silvin-lubecki
force-pushed
the
orchestrator-column
branch
from
8b27b4b to
8108934
Compare
Contributor
Author
|
Don't know what you are talking about 😅 |
vdemeester
approved these changes
Mar 28, 2018
Collaborator
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
LGTM on commit 8108934
silvin-lubecki
force-pushed
the
orchestrator-column
branch
from
8108934 to
762d84c
Compare
thaJeztah
requested changes
Apr 26, 2018
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
left one comment for documentation, but otherwise looks good.
I added [WIP] to the PR title, as this depends on the other PR's being merged first
| "Services": stackServicesHeader, | ||
| "Name": nameHeader, | ||
| "Services": stackServicesHeader, | ||
| "Orchestrator": stackOrchestrastorHeader, |
Member
There was a problem hiding this comment.
Can you:
- Add the new
Orchestratorplaceholder to the "formatting" section in the docs: https://github.com/docker/cli/blob/master/docs/reference/commandline/stack_ls.md#formatting - Update the
Examplessection to show the new column?
Member
There was a problem hiding this comment.
This should be fixed, can you PTAL? Thanks!
mat007
force-pushed
the
orchestrator-column
branch
from
762d84c to
a4e4924
Compare
thaJeztah
approved these changes
Apr 30, 2018
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM after the other PR's are merged and this is rebased
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
mat007
force-pushed
the
orchestrator-column
branch
from
a4e4924 to
13d0c9c
Compare
Member
|
Rebased (and squashed the doc update) ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
To perform administration tasks more easily, I added an ORCHESTRATOR column in the
docker stack lscommand.- How I did it
I added a column in the Stack formatter, and hardcoded the orchestrator in each list command implementation.
- How to verify it
- Description for the changelog
Added ORCHESTRATOR column to docker stack ls command
- A picture of a cute animal (not mandatory but encouraged)
