Makefile: Fix copy-paste mistakes in the Makefile #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some variables was copied from the compose Makefile without having all the variables declared. Added `PKG_NAME` so we have working `internal.Version` and removed the removal of `e2e` tests since they are not in this repository. Signed-off-by: Morten Linderud <morten@linderud.pw>
Contributor
Author
|
I realized the title might not be super descriptive and maybe read a bit passive aggressive which wasn't my intention. If it should be fixed please do say so :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some variables was copied from the compose Makefile without having all
the variables declared. Added
PKG_NAMEso we have workinginternal.Versionand removed the removal ofe2etests since they arenot in this repository.
Signed-off-by: Morten Linderud morten@linderud.pw