Error when specifying permission in volume

[hackzilla]

root@dev-stats-web:~# fig up
Recreating root_statssymfony_1...
Traceback (most recent call last):
  File "/usr/local/bin/fig", line 9, in <module>
    load_entry_point('fig==0.4.2', 'console_scripts', 'fig')()
  File "/usr/local/lib/python2.7/dist-packages/fig/cli/main.py", line 39, in main
    command.sys_dispatch()
  File "/usr/local/lib/python2.7/dist-packages/fig/cli/docopt_command.py", line 21, in sys_dispatch
    self.dispatch(sys.argv[1:], None)
  File "/usr/local/lib/python2.7/dist-packages/fig/cli/command.py", line 31, in dispatch
    super(Command, self).dispatch(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/fig/cli/docopt_command.py", line 24, in dispatch
    self.perform_command(*self.parse(argv, global_options))
  File "/usr/local/lib/python2.7/dist-packages/fig/cli/command.py", line 50, in perform_command
    return super(Command, self).perform_command(options, *args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/fig/cli/docopt_command.py", line 27, in perform_command
    handler(command_options)
  File "/usr/local/lib/python2.7/dist-packages/fig/cli/main.py", line 306, in up
    to_attach = self.project.up(service_names=options['SERVICE'])
  File "/usr/local/lib/python2.7/dist-packages/fig/project.py", line 131, in up
    for (_, new) in service.recreate_containers():
  File "/usr/local/lib/python2.7/dist-packages/fig/service.py", line 173, in recreate_containers
    tuples.append(self.recreate_container(c, **override_options))
  File "/usr/local/lib/python2.7/dist-packages/fig/service.py", line 195, in recreate_container
    self.start_container(new_container, volumes_from=intermediate_container.id)
  File "/usr/local/lib/python2.7/dist-packages/fig/service.py", line 225, in start_container
    external_dir, internal_dir = volume.split(':')
ValueError: too many values to unpack

Took me a while to figure out I'd added :rw to the fig.yml

  volumes:
   - stats-symfony/logs:/var/log/nginx:rw

Would be good idea to add a warning, or support it.

[aanand]

Added to #129.

[amalagaura]

How do we specify :ro to the fig.yml for volumes

[montells]

How do we specify :ro to the fig.yml for volumes

http://stackoverflow.com/questions/25385164/how-to-specify-write-access-to-volume-with-fig

[prologic]

+1

[prologic]

Commits from @dnephin look great to me :) Can we get this merged in?

[prologic]

I solved this locally with minor change:

diff --git a/fig/service.py b/fig/service.py
--- a/fig/service.py
+++ b/fig/service.py
@@ -232,10 +232,17 @@
         if options.get('volumes', None) is not None:
             for volume in options['volumes']:
                 if ':' in volume:
-                    external_dir, internal_dir = volume.split(':')
+                    tokens = volume.split(":")
+
+                    if len(tokens) == 3:
+                        external_dir, internal_dir, ro = tokens
+                    else:
+                        external_dir, internal_dir = tokens
+                        ro = "rw"
+
                     volume_bindings[os.path.abspath(external_dir)] = {
                         'bind': internal_dir,
-                        'ro': False,
+                        'ro': ro.lower() == "ro"
                     }

         privileged = options.get('privileged', False)

[alexandresalome]

💥 hitting same problem