Support docker exec command

[k4nar]

I've just learned about the new docker exec command. Wouldn't it be great to add it to fig ?

I think it really makes sense with fig, as you could run fig up and then exec some commands (like a shell) to debug your running containers if something happen.
Of course this is already possible by running docker exec -it your_container cmd, but I think that it wouldn't hurt to have fig exec service cmd.

I'll try to give it a shot and submit a PR.

[bfirsh]

👍

Thanks @k4nar! Contribution docs are here: https://github.com/docker/fig/blob/master/CONTRIBUTING.md#tldr

[k4nar]

I think we'll have to wait for docker/docker-py#363 to land.

[imsickofmaps]

Just an FYI as I clicked through this link, docker/docker-py#363 has landed

[k4nar]

I'm working on it. I have something working for simple commands, like fig exec web echo "Hello World!", but I don't know yet how to make it works with applications using TTYs.
I'm looking at dockerpty but I think it will require some modifications, as for now it only handles the client.start method.
If anyone with more experience than me on the subject wants to help it's welcome :) . You can reach me here or on IRC.

[pikeas]

+1!

[Stono]

+1

[andradei]

👍

[hadim]

+1

[hadim]

It would also be nice to be able to define exec command in fig.yml.

[baptistedonaux]

+1 Yes I would it !

[Grokzen]

+1

[jhftrifork]

+1

[dnephin]

docker exec is already "supported" by the docker cli

docker exec <container name>

This really wouldn't change with docker-compose, you'd just use the service name instead of the container name. It doesn't seem to me like exec is really a feature of composition. In the same way that docker-compose doesn't duplicate docker inspect or docker import. Those are very much operations for individual containers, so they don't really need to exist in compose.