pkg/compose: RunOneOffContainer: don't use NewStartOptions() #10828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
approved these changes
Jul 19, 2023
It's no longer used in docker/cli, and doesn't do anything other than creating an empty struct, so replacing it (as we're planning to deprecate that function) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
glours
force-pushed
the
minor_cli_changes
branch
from
b900442 to
4eb43c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's no longer used in docker/cli, and doesn't do anything other than creating an empty struct, so replacing it (as we're planning to deprecate that function)
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did