Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions compose/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,12 @@ def merge_service_dicts(base, override):
override.get('volumes'),
)

if 'image' in override and 'build' in d:
del d['build']

if 'build' in override and 'image' in d:
del d['image']

for k in ALLOWED_KEYS:
if k not in ['environment', 'volumes']:
if k in override:
Expand Down
33 changes: 33 additions & 0 deletions tests/unit/config_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,39 @@ def test_merge_volumes_remove_explicit_path(self):
)
self.assertEqual(set(service_dict['volumes']), set(['/bar:/code', '/data']))

def test_merge_build_or_image_no_override(self):
self.assertEqual(
config.merge_service_dicts({'build': '.'}, {}),
{'build': '.'},
)

self.assertEqual(
config.merge_service_dicts({'image': 'redis'}, {}),
{'image': 'redis'},
)

def test_merge_build_or_image_override_with_same(self):
self.assertEqual(
config.merge_service_dicts({'build': '.'}, {'build': './web'}),
{'build': './web'},
)

self.assertEqual(
config.merge_service_dicts({'image': 'redis'}, {'image': 'postgres'}),
{'image': 'postgres'},
)

def test_merge_build_or_image_override_with_other(self):
self.assertEqual(
config.merge_service_dicts({'build': '.'}, {'image': 'redis'}),
{'image': 'redis'}
)

self.assertEqual(
config.merge_service_dicts({'image': 'redis'}, {'build': '.'}),
{'build': '.'}
)


class EnvTest(unittest.TestCase):
def test_parse_environment_as_list(self):
Expand Down