Skip to content

Conversation

@ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jan 8, 2025

What I did
removed "building" events are the progress UX collides with buildkit on terminal
only keep "built" events after all images have been built as a general status after build succeeded

Related issue
fixes #12370

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested a review from glours January 8, 2025 14:57
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests ok 👍

@ndeloof ndeloof merged commit a351585 into docker:main Jan 8, 2025
24 checks passed
@ndeloof ndeloof deleted the flicker branch January 8, 2025 15:13
felixfontein added a commit to felixfontein/community.docker that referenced this pull request Jan 14, 2025
This has been caused by docker/compose#12442,
since that PR removes the "building" event.
felixfontein added a commit to ansible-collections/community.docker that referenced this pull request Jan 14, 2025
* Since docker-compose 2.32.2 present_3 is no longer changed.

This has been caused by docker/compose#12442,
since that PR removes the "building" event.

* Remove deprecated 'version' fields.
felixfontein added a commit to ansible-collections/community.docker that referenced this pull request Jan 14, 2025
* Since docker-compose 2.32.2 present_3 is no longer changed.

This has been caused by docker/compose#12442,
since that PR removes the "building" event.

* Remove deprecated 'version' fields.

(cherry picked from commit 9e26c47)
@stephaneredpill
Copy link

Awesome, tested successfully on my Intel Mac. Thanks.

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jan 26, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker/compose](https://github.com/docker/compose) | patch | `v2.32.2` -> `v2.32.4` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>docker/compose (docker/compose)</summary>

### [`v2.32.4`](https://github.com/docker/compose/releases/tag/v2.32.4)

[Compare Source](docker/compose@v2.32.3...v2.32.4)

#### What's Changed

This release fixes the version issue of `v2.32.3`

##### 🔧  Internal

-   ci: use local source for binary builds by [@&#8203;crazy-max](https://github.com/crazy-max) in docker/compose#12470
-   ci: re-use local source to build binary images by [@&#8203;glours](https://github.com/glours) in docker/compose#12471
-   add missing tag for build during merge workflow by [@&#8203;glours](https://github.com/glours) in docker/compose#12473

**Full Changelog**: docker/compose@v2.32.3...v2.32.4

### [`v2.32.3`](https://github.com/docker/compose/releases/tag/v2.32.3)

[Compare Source](docker/compose@v2.32.2...v2.32.3)

#### What's Changed

⚠️ This release don't display properly its version! Instead of displaying the tag the `docker compose version` display its commit hash.

##### 🐛 Fixes

-   Only override service mac if set on the main network. by [@&#8203;apollo13](https://github.com/apollo13) [(12439)](docker/compose#12439)
-   Exclude one-off container running convergence by [@&#8203;ndeloof](https://github.com/ndeloof) [(12441)](docker/compose#12441)
-   Can't render progress concurrently with buildkit by [@&#8203;ndeloof](https://github.com/ndeloof) [(12442)](docker/compose#12442)
-   Image can be set to a local ID, that isn't a valid docker ref by [@&#8203;ndeloof](https://github.com/ndeloof) [(12446)](docker/compose#12446)

##### 🔧  Internal

-   CI: update bake-action to v6 by [@&#8203;crazy-max](https://github.com/crazy-max) [(12452)](docker/compose#12452)
-   Simplification by [@&#8203;ndeloof](https://github.com/ndeloof) [(12451)](docker/compose#12451)

**Full Changelog**: docker/compose@v2.32.2...v2.32.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMjIuMCIsInVwZGF0ZWRJblZlciI6IjM5LjEyMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Overlapping print rows while building

3 participants