fix: Revert user-agent for docker cli client #12516
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Removed custom user-agent for docker cli client(that was added within this PR), because docker docker desktop's does specific logic depending on the user agent. The latest docker compose takes 3 seconds to do a request to the docker daemon.
More details here docker/for-mac#7575 (comment)
I also tried the ping method(internal/desktop/client.go:78) with the new user agent and it works fine, so decided to left it as is.
Related issue
#12511
p.s. I'm not sure should we change logic here or the docker desktop should start accepting the new user-agent, feel free to close this PR in case of the second case
@milas fyi