Skip to content

Conversation

@aanand
Copy link

@aanand aanand commented Apr 7, 2015

Closes #1255. Regressed with the config.py refactoring.

@aanand aanand force-pushed the fix-vars-in-volume-paths branch from 1f957c8 to 43f3741 Compare April 7, 2015 15:17
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
@aanand aanand force-pushed the fix-vars-in-volume-paths branch from 43f3741 to fd568b3 Compare April 7, 2015 15:23
@aanand aanand added this to the 1.2.0 milestone Apr 7, 2015
@bfirsh
Copy link

bfirsh commented Apr 9, 2015

LGTM

bfirsh added a commit that referenced this pull request Apr 9, 2015
@bfirsh bfirsh merged commit 4926f8a into docker:master Apr 9, 2015
@aanand aanand removed the in progress label Apr 9, 2015
@aanand aanand deleted the fix-vars-in-volume-paths branch April 9, 2015 13:44
aanand pushed a commit to aanand/fig that referenced this pull request Apr 9, 2015
Fix vars in volume paths
(cherry picked from commit 4926f8a)

Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>

Conflicts:
	tests/unit/service_test.py
yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
Fix vars in volume paths
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
Fix vars in volume paths
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
StefanScherer added a commit to hypriot/compose that referenced this pull request Apr 19, 2015
* tag '1.2.0': (46 commits)
  Bump 1.2.0
  Merge pull request docker#1278 from albers/completion-run-user
  Merge pull request docker#1261 from aanand/fix-vars-in-volume-paths
  Merge pull request docker#1202 from aanand/jenkins-script
  Merge pull request docker#1213 from moysesb/relative_build
  Merge pull request docker#1226 from aanand/merge-multi-value-options
  Merge pull request docker#1225 from aanand/fix-1222
  Fix regression in Dns and DnsSearch settings
  Fix volume merging when there's no explicit host path
  Fix service dict merging when only one dict has a volumes key
  Update docker-py and requests version ranges
  Revert "Remove restriction for requests version, update docker-py requirement"
  Revert "Use dev version of Docker"
  Revert "Add 'labels:' config option"
  Add 'labels:' config option
  Use dev version of Docker
  Make volume host paths relative to file, merge volumes when extending
  Implement `extends`
  Specify all HostConfig at create time
  Add build status \o/
  ...

Conflicts:
	Dockerfile
	README.md
	script/build-linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

volumes: absolute path becomes relative if it is in an environment variable

2 participants