Skip to content

add support for external binary with provider services #12781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
glours wants to merge 1 commit into from
Closed

add support for external binary with provider services #12781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions pkg/compose/plugins.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,19 @@ func (s *composeService) runPlugin(ctx context.Context, project *types.Project,

plugin, err := s.getPluginBinaryPath(provider.Type)
if err != nil {
return err
if !strings.Contains(err.Error(), "Error: No such CLI plugin") {
Copy link
Contributor

@ndeloof ndeloof Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manager.IsNotFound

return err
}
// look if there is a binary with this name in the path
path, err := exec.LookPath(provider.Type)
if err != nil {
return err
}
plugin = &manager.Plugin{
Name: provider.Type,
Path: path,
}
}

if err := s.checkPluginEnabledInDD(ctx, plugin); err != nil {
return err
}
Expand Down Expand Up @@ -195,8 +205,7 @@ func (s *composeService) checkPluginEnabledInDD(ctx context.Context, plugin *man
return fmt.Errorf("you should enable model runner to use %q provider services: %s", plugin.Name, err.Error())
}
}
} else {
return fmt.Errorf("unsupported provider %q", plugin.Name)
return err
}
return nil
}