Improve error when service is not a dict #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Lots more validation we can and should be doing - I'll create a separate issue for that. |
7 tasks
aanand
added a commit
that referenced
this pull request
Mar 3, 2014
…ice-is-not-dict Improve error when service is not a dict
yuval-k
pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
…n-service-is-not-dict Improve error when service is not a dict Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
xulike666
pushed a commit
to xulike666/compose
that referenced
this pull request
Jan 19, 2017
Fix userns mapping for tty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127