Skip to content

Fixed a possible leak bug in goroutine #13108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
suwakei wants to merge 1 commit into from
Closed

Fixed a possible leak bug in goroutine #13108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions cmd/formatter/stopping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package formatter

import (
"context"
"fmt"
"strings"
"time"
Expand All @@ -26,12 +27,15 @@ import (
"github.com/docker/compose/v2/pkg/progress"
)

const tickerInterval = 100 * time.Millisecond

type Stopping struct {
api.LogConsumer
enabled bool
spinner *progress.Spinner
ticker *time.Ticker
startedAt time.Time
cancel context.CancelFunc
}

func NewStopping(l api.LogConsumer) *Stopping {
Expand All @@ -56,20 +60,27 @@ func (s *Stopping) ApplicationTermination() {
s.spinner = progress.NewSpinner()
hideCursor()
s.startedAt = time.Now()
s.ticker = time.NewTicker(100 * time.Millisecond)
s.ticker = time.NewTicker(tickerInterval)

ctx, cancel := context.WithCancel(context.Background())
s.cancel = cancel

go func() {
for {
<-s.ticker.C
s.print()
select {
case <-s.ticker.C:
s.print()
case <-ctx.Done():
return
}
}
}()
}

func (s *Stopping) Close() {
showCursor()
if s.ticker != nil {
s.ticker.Stop()
}
s.ticker.Stop()
s.cancel()
s.clear()
}

Expand Down