Skip to content

Fix build slowdown when OpenTelemetry Exporter env variables are present #13163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxproske wants to merge 1 commit into from
Closed

Fix build slowdown when OpenTelemetry Exporter env variables are present #13163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/compose/shellout.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package compose
import (
"context"
"os/exec"
"strings"

"github.com/compose-spec/compose-go/v2/types"
"github.com/docker/cli/cli-plugins/metadata"
Expand All @@ -34,6 +35,13 @@ func (s *composeService) prepareShellOut(gctx context.Context, env types.Mapping
// remove DOCKER_CLI_PLUGIN... variable so a docker-cli plugin will detect it run standalone
delete(env, metadata.ReexecEnvvar)

// Remove OpenTelemetry env variables so buildx doesn't attempt to init exporter and timeout
for k := range env {
if strings.HasPrefix(k, "OTEL_") {
delete(env, k)
}
}

// propagate opentelemetry context to child process, see https://github.com/open-telemetry/oteps/blob/main/text/0258-env-context-baggage-carriers.md
carrier := propagation.MapCarrier{}
otel.GetTextMapPropagator().Inject(gctx, &carrier)
Expand Down