Skip to content

configure Compose service with io.Reader and io.Writer #13322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndeloof merged 1 commit into from
Oct 27, 2025
Merged

configure Compose service with io.Reader and io.Writer #13322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 0 additions & 43 deletions pkg/api/io.go
View file
Open in desktop

This file was deleted.

14 changes: 7 additions & 7 deletions pkg/compose/compose.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func NewComposeService(dockerCli command.Cli, options ...Option) (api.Compose, e
}

// WithStreams sets custom I/O streams for output and interaction
func WithStreams(out, err api.OutputStream, in api.InputStream) Option {
func WithStreams(out, err io.Writer, in io.Reader) Option {
return func(s *composeService) error {
s.outStream = out
s.errStream = err
Expand All @@ -114,23 +114,23 @@ func WithStreams(out, err api.OutputStream, in api.InputStream) Option {
}

// WithOutputStream sets a custom output stream
func WithOutputStream(out api.OutputStream) Option {
func WithOutputStream(out io.Writer) Option {
return func(s *composeService) error {
s.outStream = out
return nil
}
}

// WithErrorStream sets a custom error stream
func WithErrorStream(err api.OutputStream) Option {
func WithErrorStream(err io.Writer) Option {
return func(s *composeService) error {
s.errStream = err
return nil
}
}

// WithInputStream sets a custom input stream
func WithInputStream(in api.InputStream) Option {
func WithInputStream(in io.Reader) Option {
return func(s *composeService) error {
s.inStream = in
return nil
Expand Down Expand Up @@ -197,9 +197,9 @@ type composeService struct {
prompt Prompt

// Optional overrides for specific components (for SDK users)
outStream api.OutputStream
errStream api.OutputStream
inStream api.InputStream
outStream io.Writer
errStream io.Writer
inStream io.Reader
contextInfo api.ContextInfo
proxyConfig map[string]string

Expand Down