inject ENV variables to yaml #1338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Kadenbach <matthias.kadenbach@gmail.com>
|
#685 does this as well and allows defaults. |
|
#76 took a very similar approach. The problem with the approach is that it makes it really easy to corrupt your yaml, or even allows unexpected environment variables to add new sections, services or even commands to compose, which could be used maliciously. I strongly believe environment substitution needs to happen on a per-fiend basis. It's more work, but it's much safer. |
|
This is done in #1765 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inject ENV variables to yaml
#1287