Skip to content

Introduced a build tag to select watcher implementation. #13452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glours merged 1 commit into from
Dec 15, 2025
+8 −4
Merged

Introduced a build tag to select watcher implementation. #13452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ ifeq ($(DETECTED_OS),Windows)
BINARY_EXT=.exe
endif

ifeq ($(DETECTED_OS),Darwin)
GO_BUILDTAGS += fsnotify
endif

BUILD_FLAGS?=
TEST_FLAGS?=
E2E_TEST?=
Expand Down Expand Up @@ -62,11 +66,11 @@ build:

.PHONY: binary
binary:
$(BUILDX_CMD) bake binary
BUILD_TAGS="$(GO_BUILDTAGS)" $(BUILDX_CMD) bake binary

.PHONY: binary-with-coverage
binary-with-coverage:
$(BUILDX_CMD) bake binary-with-coverage
BUILD_TAGS="$(GO_BUILDTAGS)" $(BUILDX_CMD) bake binary-with-coverage

.PHONY: install
install: binary
Expand Down
2 changes: 1 addition & 1 deletion pkg/watch/watcher_darwin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build darwin
//go:build fsnotify

/*
Copyright 2020 Docker Compose CLI authors
Expand Down
2 changes: 1 addition & 1 deletion pkg/watch/watcher_naive.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build !darwin
//go:build !fsnotify

/*
Copyright 2020 Docker Compose CLI authors
Expand Down