Share /etc/hosts option #1375
Closed
Share /etc/hosts option #1375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontainers such that each container within a docker composition can resolve the hostname of the others belonging to the same composition. Signed-off-by: Marco Enrico Piras <kikkomep@crs4.it>
Signed-off-by: Marco Enrico Piras <kikkomep@crs4.it>
|
Thanks for the PR. It's an interesting idea, but hostname resolution is what links (and the upcoming networking idioms) are for. This looks like a bit of a hack. What's the use case? |
Author
|
The problem using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option
--share-etc-hoststoupandscalecommands allowing hostname resolution between containers.